Sorry for the necro-review-thread nitpicking... On Fri, Feb 1, 2013 at 4:36 PM, David Blaikie <[email protected]> wrote: > Author: dblaikie > Date: Fri Feb 1 18:36:58 2013 > New Revision: 174248 > > URL: http://llvm.org/viewvc/llvm-project?rev=174248&view=rev > Log: > Sentenc-ify comment added in r174206. > > Based on post-commit review by Paul Robinson. > > Modified: > cfe/trunk/lib/CodeGen/CodeGenFunction.cpp > > Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenFunction.cpp?rev=174248&r1=174247&r2=174248&view=diff > ============================================================================== > --- cfe/trunk/lib/CodeGen/CodeGenFunction.cpp (original) > +++ cfe/trunk/lib/CodeGen/CodeGenFunction.cpp Fri Feb 1 18:36:58 2013 > @@ -144,8 +144,8 @@ void CodeGenFunction::EmitReturnBlock() > if (BI && BI->isUnconditional() && > BI->getSuccessor(0) == ReturnBlock.getBlock()) { > // Reset insertion point, including debug location, and delete the > branch. > - // this is really subtle & only works because the next change in > location > - // will hit the caching in CGDebugInfo::EmitLocation & not override > this > + // This is really subtle & only works because the next change in > location > + // will hit the caching in CGDebugInfo::EmitLocation & not override > this.
I'd generally prefer "and" to "&" in prose. > Builder.SetCurrentDebugLocation(BI->getDebugLoc()); > Builder.SetInsertPoint(BI->getParent()); > BI->eraseFromParent(); > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
