[bcc: llvm-commits, cc: cfe-commits]
2013/2/25 Timur Iskhodzhanov <[email protected]>: > Hi John, > > Attached is a preliminary patch for ctors in -cxx-abi microsoft. > > It adds: > - support for out-of-class constructor definitions (PR12784), > - reading and writing proper ctor arguments when dealing with virtual bases. > I also tried this patch on some "build, run and verify" tests for > virtual inheritance vs ctors and it works great. > > Can you please take a look at the implementation and tell me if there > are any logical mistakes? > > Also, I've put two TODOs in the code with questions. > It would be nice if you could take a look at the logic first and > suggest me if my CGCXXABI abstraction plans are sane - before I copy > any code between files. > > If the logic of the patch and the abstraction suggestions are fine, > I'll move the code around as described and prepare a patch ready for > review. > > Thanks! > -- > Timur
ctors.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
