On Mar 3, 2013 7:39 AM, "David Chisnall" <[email protected]> wrote: > > Author: theraven > Date: Sun Mar 3 09:36:10 2013 > New Revision: 176419 > > URL: http://llvm.org/viewvc/llvm-project?rev=176419&view=rev > Log: > Default to enabling default-synthesized ivars on all platforms
That you could change this without causing any failures seems to indicate there's some missing test coverage I would think. Could you add a test? > > Modified: > cfe/trunk/include/clang/Driver/ToolChain.h > cfe/trunk/lib/Driver/ToolChains.h > > Modified: cfe/trunk/include/clang/Driver/ToolChain.h > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/ToolChain.h?rev=176419&r1=176418&r2=176419&view=diff > ============================================================================== > --- cfe/trunk/include/clang/Driver/ToolChain.h (original) > +++ cfe/trunk/include/clang/Driver/ToolChain.h Sun Mar 3 09:36:10 2013 > @@ -147,7 +147,7 @@ public: > > /// IsObjCDefaultSynthPropertiesDefault - Does this tool chain enable > /// -fobjc-default-synthesize-properties by default. > - virtual bool IsObjCDefaultSynthPropertiesDefault() const { return false; } > + virtual bool IsObjCDefaultSynthPropertiesDefault() const { return true; } > > /// IsEncodeExtendedBlockSignatureDefault - Does this tool chain enable > /// -fencode-extended-block-signature by default. > > Modified: cfe/trunk/lib/Driver/ToolChains.h > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.h?rev=176419&r1=176418&r2=176419&view=diff > ============================================================================== > --- cfe/trunk/lib/Driver/ToolChains.h (original) > +++ cfe/trunk/lib/Driver/ToolChains.h Sun Mar 3 09:36:10 2013 > @@ -297,10 +297,6 @@ public: > return false; > } > > - virtual bool IsObjCDefaultSynthPropertiesDefault() const { > - return true; > - } > - > virtual bool IsEncodeExtendedBlockSignatureDefault() const { > return true; > } > @@ -564,10 +560,6 @@ public: > virtual Tool &SelectTool(const Compilation &C, const JobAction &JA, > const ActionList &Inputs) const; > > - virtual bool IsObjCDefaultSynthPropertiesDefault() const { > - return true; > - } > - > virtual bool IsIntegratedAssemblerDefault() const; > virtual bool IsUnwindTablesDefault() const; > virtual bool isPICDefault() const; > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
