On Mar 4, 2013, at 6:43 PM, Dmitri Gribenko <[email protected]> wrote:
> On Tue, Mar 5, 2013 at 1:34 AM, Albert Wong (王重傑) <[email protected]> wrote: >> Hello, >> >> I have a small patch to regex_traits for fixing some compile errors I ran >> into building for MIPS Android. I updated the patch to Phabricator per >> these instructions but I have no clue who to add as a reviewer. The svn >> logs make it look like it should be hhinnant, but Phabricator rejects Howard >> as a reviewer. :-/ >> >> Anyways, the patch is here: >> >> http://llvm-reviews.chandlerc.com/D492 >> >> It's a pretty simple 5 liner. > > Albert, > > libcxx patches should be sent to cfe-commits. > > (Adding cfe-commits and Howard Hinnant) Thanks Dmitri. Thanks Albert. I traditionally like to leave the constant specifier in the class definition: static const char_class_type __regex_word = 0x80; If we just add this: template <class _CharT> const typename regex_traits<_CharT>::char_class_type regex_traits<_CharT>::__regex_word; will that work in your environment? Howard _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
