Hi Chris, Your patch looks good to me. Looking at the code I could not figure out, how the default cores are decided. However, as I am also not an expert in this area, I will others comment on the default core behaviour.
Regards, Manish > ---------- Forwarded message ---------- > From: Chris Cadwallader <[email protected]> > Date: Tue, Mar 5, 2013 at 7:06 AM > Subject: [PATCH] Add default armv5te CPU to getLLVMSuffixForArm table > To: "[email protected]" <[email protected]> > > > The attached patch adds the default armv5[t]e target CPU to the > getLLVMSuffixForArm table and corrects a typo (missing hyphen). This > is needed for clang to generate the proper target triple when -emit- > llvm is passed to the driver because arm1026ej-s did not have an > entry and returned the default of arm7tdmi. I have some reservation > that the default for armv5[t]e makes more sense to be arm1022e to > begin with, but I am by no means an expert so this immediately > addresses the problem. > > <repro> > simple.c: > int main() { return 0;} > > clang -O0 -emit-llvm -target armv5te-none-linux-gnueabi -c -o > simple.bc simple.c > llvm-dis simple.bc > Observe incorrect target triple of arm-none-linux-gnueabi > </repro> > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
