Hi Matthew, Is the motivation just as a cleanup?
Specific comments on the patch: 1. getCompilationPhases should take the phase list as a reference not a pointer, this is more consistent. 2. Don't .clear() the list in getCompilationPhases. 3. There aren't enough uses to be worth introducing the PhaseList type, just write out the SmallVector which makes the code more verbose but more familiar. - Daniel On Wed, Mar 6, 2013 at 6:04 AM, Matthew Curtis <[email protected]>wrote: > Hello Daniel, > > Do you have time to comment on this patch? > > Thanks, > Matthew Curtis. > > > On 3/1/2013 4:17 PM, Matthew Curtis wrote: > > There is now a single function to get the list of phases for a given > output Type. > > No functionality change intended. > > Thanks, > Matthew Curtis > > > > _______________________________________________ > cfe-commits mailing > [email protected]http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by > The Linux Foundation > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
