In this patch I'm mostly interested in your thoughts on using 'auto &&' instead 
of 'auto'. I first tried 'const auto &' but this introduces more cv 
qualification.

-----Original Message-----
From: Edwin Vane [mailto:[email protected]] 
Sent: Wednesday, March 06, 2013 2:57 PM
To: [email protected]; [email protected]; Vane, Edwin
Cc: [email protected]
Subject: [PATCH] Have LoopConvert use 'auto &&' where necessary

Hi gribozavr, klimek,

For iterators where the dereference operator returns by value, LoopConvert 
should use 'auto &&' in the range-based for loop expression.

Moved test case from iterator_failing.cpp to iterator.cpp and added extra tests.

Fixes PR15437.

http://llvm-reviews.chandlerc.com/D500

Files:
  cpp11-migrate/LoopConvert/LoopActions.cpp
  cpp11-migrate/LoopConvert/LoopActions.h
  cpp11-migrate/LoopConvert/LoopMatchers.cpp
  cpp11-migrate/LoopConvert/LoopMatchers.h
  test/cpp11-migrate/LoopConvert/Inputs/structures.h
  test/cpp11-migrate/LoopConvert/iterator.cpp
  test/cpp11-migrate/LoopConvert/iterator_failing.cpp

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to