LGTM. From: Murat Bolat Sent: 07 March 2013 13:48 To: [email protected] Cc: 'Benyei, Guy'; Joey Gouly Subject: RE: [OpenCL patch] vec_type_hint
Hi, I incorporated the Guy Benyei's patch and modified the patch based on Joey Gouly's suggestion. I attached the patch for the vec_type_hint attribute. Thanks a lot! Murat Bolat From: Benyei, Guy [mailto:[email protected]] Sent: 07 March 2013 11:28 To: Murat Bolat; [email protected] Subject: RE: [OpenCL patch] vec_type_hint Hi, I think you should use a pattern similar to the ones used in other attributes, instead of adding a qualtype field to AttributeList that's not in use most of the time. Attached my implementation for this part of the patch, please take a look at it. Thanks From: [email protected] [mailto:[email protected]] On Behalf Of Murat Bolat Sent: Wednesday, March 06, 2013 20:04 To: [email protected] Subject: [OpenCL patch] vec_type_hint Hi all, Here is the updated patch for vec_type_hint attribute in OpenCL. The previous discussion about it: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120813/062502.html Thanks a lot! Murat Bolat -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
