Here is the patch for moving back the clang tests, and using REQUIRES: asserts.
On Fri, Mar 8, 2013 at 3:46 PM, Jan Voung <[email protected]> wrote: > Ah, I didn't know there was a REQUIRES: asserts. I can revert the test > moves and do that instead. > > > On Fri, Mar 8, 2013 at 3:33 PM, Chandler Carruth <[email protected]>wrote: > >> On Fri, Mar 8, 2013 at 2:42 PM, Jan Wen Voung <[email protected]> wrote: >> >>> Author: jvoung >>> Date: Fri Mar 8 16:42:02 2013 >>> New Revision: 176730 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=176730&view=rev >>> Log: >>> Move clang tests that depend on llvm/ADT/Statistic.h to a subdir. >>> >>> The subdirectory has a lit.local.cfg that marks the tests unsupported >>> if llvm was built without Asserts. There will be a patch in LLVM >>> that disables statistics gathering when built without Asserts so >>> that full Release builds can be faster. Statistics can also >>> be enabled by building with -DLLVM_ENABLE_STATS. >>> >> >> Rather than adding more directories, why not just add REQUIRES: asserts >> to this? >> >> >>> >>> Added: >>> cfe/trunk/test/Analysis/Stats/ >>> cfe/trunk/test/Analysis/Stats/lit.local.cfg >>> cfe/trunk/test/Analysis/Stats/objc-method-coverage.m (contents, >>> props changed) >>> - copied, changed from r176717, >>> cfe/trunk/test/Analysis/objc-method-coverage.m >>> cfe/trunk/test/Analysis/Stats/stats.c (contents, props changed) >>> - copied, changed from r176717, cfe/trunk/test/Analysis/stats.c >>> Removed: >>> cfe/trunk/test/Analysis/objc-method-coverage.m >>> cfe/trunk/test/Analysis/stats.c >>> >>> Added: cfe/trunk/test/Analysis/Stats/lit.local.cfg >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/Stats/lit.local.cfg?rev=176730&view=auto >>> >>> ============================================================================== >>> --- cfe/trunk/test/Analysis/Stats/lit.local.cfg (added) >>> +++ cfe/trunk/test/Analysis/Stats/lit.local.cfg Fri Mar 8 16:42:02 2013 >>> @@ -0,0 +1,4 @@ >>> +config.suffixes = ['.c', '.cpp', '.m', '.mm', '.cu', '.ll', '.cl', '.s'] >>> + >>> +if 'asserts' not in config.root.available_features: >>> + config.unsupported = True >>> >>> Copied: cfe/trunk/test/Analysis/Stats/objc-method-coverage.m (from >>> r176717, cfe/trunk/test/Analysis/objc-method-coverage.m) >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/Stats/objc-method-coverage.m?p2=cfe/trunk/test/Analysis/Stats/objc-method-coverage.m&p1=cfe/trunk/test/Analysis/objc-method-coverage.m&r1=176717&r2=176730&rev=176730&view=diff >>> >>> ============================================================================== >>> (empty) >>> >>> Propchange: cfe/trunk/test/Analysis/Stats/objc-method-coverage.m >>> >>> ------------------------------------------------------------------------------ >>> svn:eol-style = LF >>> >>> Copied: cfe/trunk/test/Analysis/Stats/stats.c (from r176717, >>> cfe/trunk/test/Analysis/stats.c) >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/Stats/stats.c?p2=cfe/trunk/test/Analysis/Stats/stats.c&p1=cfe/trunk/test/Analysis/stats.c&r1=176717&r2=176730&rev=176730&view=diff >>> >>> ============================================================================== >>> (empty) >>> >>> Propchange: cfe/trunk/test/Analysis/Stats/stats.c >>> >>> ------------------------------------------------------------------------------ >>> svn:eol-style = LF >>> >>> Removed: cfe/trunk/test/Analysis/objc-method-coverage.m >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/objc-method-coverage.m?rev=176729&view=auto >>> >>> ============================================================================== >>> --- cfe/trunk/test/Analysis/objc-method-coverage.m (original) >>> +++ cfe/trunk/test/Analysis/objc-method-coverage.m (removed) >>> @@ -1,16 +0,0 @@ >>> -// RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-stats >>> -fblocks %s 2>&1 | FileCheck %s >>> -@interface I >>> -int f() { >>> - return 0; >>> -} >>> -@end >>> - >>> -@implementation I >>> -+ (void *)ff{ >>> - return (void*)0; >>> -} >>> -@end >>> - >>> -// CHECK: ... Statistics Collected ... >>> -// CHECK: 2 AnalysisConsumer - The # of functions and blocks analyzed >>> (as top level with inlining turned on). >>> -// CHECK: 100 AnalysisConsumer - The % of reachable basic blocks. >>> \ No newline at end of file >>> >>> Removed: cfe/trunk/test/Analysis/stats.c >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/stats.c?rev=176729&view=auto >>> >>> ============================================================================== >>> --- cfe/trunk/test/Analysis/stats.c (original) >>> +++ cfe/trunk/test/Analysis/stats.c (removed) >>> @@ -1,8 +0,0 @@ >>> -// RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-stats %s >>> 2>&1 | FileCheck %s >>> - >>> -void foo() { >>> - int x; >>> -} >>> -// CHECK: ... Statistics Collected ... >>> -// CHECK:100 AnalysisConsumer - The % of reachable basic blocks. >>> -// CHECK:The # of times RemoveDeadBindings is called >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> >> >> >
0001-Partly-revert-Move-clang-tests-that-depend-on-llvm-A.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
