On 03/13/2013 03:44 PM, Bill Wendling wrote:
Author: void
Date: Wed Mar 13 17:44:19 2013
New Revision: 176991
URL: http://llvm.org/viewvc/llvm-project?rev=176991&view=rev
Log:
Really fix the MIPS test.
Modified:
cfe/trunk/test/CodeGen/mips16-attr.c
Modified: cfe/trunk/test/CodeGen/mips16-attr.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/mips16-attr.c?rev=176991&r1=176990&r2=176991&view=diff
==============================================================================
--- cfe/trunk/test/CodeGen/mips16-attr.c (original)
+++ cfe/trunk/test/CodeGen/mips16-attr.c Wed Mar 13 17:44:19 2013
@@ -11,7 +11,7 @@ void __attribute__((nomips16)) nofoo (vo
// CHECK: define void @nofoo() [[NOMIPS16:#[0-9]+]]
-// CHECK: attributes [[MIPS16]] = { nounwind "mips16" {{.*}} }
+// CHECK: attributes [[MIPS16]] = { nounwind {{.*}} "mips16" {{.*}} }
-// CHECK: attributes [[NOMIPS16]] = { nounwind "nomips16" {{.*}} }
+// CHECK: attributes [[NOMIPS16]] = { nounwind {{.*}} "nomips16" {{.*}} }
Darn. I was thinking of trying this prefix match yesterday but was in a
hurry and just opted to mimick some tests that were already there. I was
nervous that other unrelated changes could break the test and they did.
Why not just :
// CHECK: attributes [[MIPS16]] = { {{.*}} "mips16" {{.*}} }
// CHECK: attributes [[NOMIPS16]] = { {{.*}} "nomips16" {{.*}} }
I go through a long test/build cycle before committing so if I miss
something or change my mind I'm looking at a bunch more elapse time
before I commit.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
