On Mar 12, 2013, at 2:30 PM, Stephen Lin <[email protected]> wrote:

> Hi,
> 
> This is a bug fix for LLVM Bugzilla bug #15485 
> (http://llvm.org/bugs/show_bug.cgi?id=15485)
> 
> Basically, llvm_unreachable is currently hit because CheckOverload assumes 
> that a new function declaration in record scope should trigger member 
> function hiding rules, but this is not the case for "friend" declarations.
> 
> I believe the code causing the issue is illegal (the friend declaration 
> should not friend the function brought into scope by the using) and should 
> result in an error; this is what happens after the patch without any extra 
> effort (although the error could possibly be improved?).

I agree that the error could be improved.  Would you mind tackling that if it's 
straightforward?  It's SemaDecl.cpp:2279.  You might need to propagate down 
isFriend.

John.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to