Edwin,

Thanks a lot for looking at this.

I played around with it for a bit until I found something that works, which is 
to precede the main command with:  # RUN: cd %p

I'm assuming this doesn't interfere with the current directory that separate 
test files will see, right?

I've tested it on both Windows and Linux, with separate build trees.

I've attached the current diff.  Do you think it's ready?

On an related note, I wonder if the testing guide needs some updating a bit 
with respect to the variables.  For example, the docs seem to indicate that I 
could use "$path" to get the current source directory, and that I should avoid 
the "%" alternative prefix, but it seems that it has to be "%p".  "$p" worked 
on Linux, but only "%p" worked on both Windows and Linux.  Perhaps someone more 
familiar with it could give it a quick pass to update it.

Thanks.

-John

From: Vane, Edwin [mailto:[email protected]]
Sent: Tuesday, March 19, 2013 9:28 AM
To: Sean Silva; Thompson, John
Cc: [email protected]
Subject: RE: modularize tests - please review

I tried running these tests on linux and they all fail when using a build 
directory separate from source directory. It looks like modularize is looking 
in the build directory for the headers listed in the input file. My guess 
modularize is using the current working directory to locate headers?  I suggest 
perhaps using a -I on the command line to modularize so you can specify the 
right directory in the source tree.

From: Sean Silva [mailto:[email protected]]
Sent: Tuesday, March 19, 2013 11:49 AM
To: Thompson, John
Cc: [email protected]<mailto:[email protected]>; Vane, Edwin
Subject: Re: modularize tests - please review

This looks alright to me, but I'd like to get a second opinion. Edwin, could 
you take a look at this?

-- Sean Silva

Attachment: modularize_tests_2.patch
Description: modularize_tests_2.patch

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to