On Sun, Mar 24, 2013 at 7:30 PM, Jiong Wang <[email protected]> wrote:
> on 2013/3/23 1:52, Chris Lattner wrote: > >> On Mar 19, 2013, at 8:58 PM, Jiong Wang <[email protected]> wrote: >> >> Hi Chris, >>> >>> could you please comment on committing TILE-Gx backend into community? >>> >> Hi Jiong, >> >> I don't have any special advice here. It sounds like the general >> functionality level is high enough. Taking it into mainline sounds great, >> so long as it is reviewed by someone. >> > > thanks. > > I will commit after rebasing & re-testing the code on latest llvm > mainline. And I will follow > http://llvm.org/docs/**HowToAddABuilder.html<http://llvm.org/docs/HowToAddABuilder.html>to > setup a TILE-Gx buildbot. > No, read what he said again: so long as it is reviewed by someone. That hasn't happened yet, and you need it to happen before you commit. As to how you can get the entire backend reviewed, I gave advice on that front in my initial response to your initial email, the very first response you got: Unfortunately, this is a *huge* amount of code, and so it is likely to take > quite some time to really get reviews on all of it. Please be patient in > that regard. The best thing you can do to help accelerate the process is to dive in and > contribute to the shared parts of the open source project to help the > current maintainers, and maybe even free up some of their time to review > your patches. Because LLVM is open source, it is really important to the > project for folks working on a specific target, backend, or application to > also help share the ongoing maintenance and improvement costs of the core > shared infrastructure in the compiler. -Chandler
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
