Thanks everyone, landed in r178111. On Wed, Mar 27, 2013 at 12:38 AM, Richard Smith <[email protected]>wrote:
> +++ b/lib/Sema/SemaExprCXX.cpp > @@ -2952,6 +2955,42 @@ static bool > CheckUnaryTypeTraitTypeCompleteness(Sema &S, > [...] > + CXXRecordDecl* RD = cast<CXXRecordDecl>(RT->getDecl()); > > Should be " *", not "* ". > > + if((RD->*HasTrivial)() && !(RD->*HasNonTrivial)()) > + return true; > > Missing space after 'if'. > > + // This trait is implemented by MSVC 2012 and needed to parse the > + // standard library headers. Specifically this is used as the logic > + // behind std::has_trivial_move_constructor (20.9.4.3). > > The trait is called std::is_trivial_move_constructible. > > Otherwise, LGTM! Thanks for picking this up. > > On Fri, Mar 22, 2013 at 4:51 AM, Aaron Ballman <[email protected]>wrote: > >> Changes LGTM based on Richard's suggestions. Waiting to make sure >> Richard agrees. :-) >> >> ~Aaron >> >> On Thu, Mar 21, 2013 at 10:58 AM, João Matos <[email protected]> >> wrote: >> > On Sat, Jan 19, 2013 at 2:12 AM, Richard Smith <[email protected]> >> > wrote: >> >> >> >> Sorry for the delay! Just a handful of things: >> > >> > >> > Hi Richard, I did the changes you requested. >> > >> > http://llvm-reviews.chandlerc.com/D567 >> > >> > -- >> > João Matos >> > _______________________________________________ >> > cfe-commits mailing list >> > [email protected] >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > >> > > -- João Matos
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
