Someone already took care of this...
On Wed, Mar 27, 2013 at 10:49 AM, Evgeniy Stepanov <[email protected]> wrote: > Yes, initializing CalleeWithThisReturn in the constructor will fix > both bugs and should be faster. I'll make the change in a moment. > > On Wed, Mar 27, 2013 at 10:38 AM, Alexey Samsonov <[email protected]> wrote: >> >> On Tue, Mar 26, 2013 at 9:29 PM, John McCall <[email protected]> wrote: >>> >>> On Mar 26, 2013, at 6:44 AM, Evgeniy Stepanov <[email protected]> >>> wrote: >>> > Author: eugenis >>> > Date: Tue Mar 26 08:44:29 2013 >>> > New Revision: 178015 >>> > >>> > URL: http://llvm.org/viewvc/llvm-project?rev=178015&view=rev >>> > Log: >>> > Fix uninitialized read of CalleeWithThisReturn. >>> > >>> > CalleeWithThisReturn can be left initialized if HasThisReturn() is >>> > false. >>> > This change reverses the order of checks in EmitFunctionEpilog such that >>> > CalleeWithThisReturn is only examined when it has a meaningful value. >>> >>> Checking CalleeWithThisReturn is much faster than making that call. We >>> should just initialize CalleeWithThisReturn properly in the constructor. >> >> >> See also http://llvm.org/bugs/show_bug.cgi?id=15598 >> >>> >>> >>> John. >>> _______________________________________________ >>> cfe-commits mailing list >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> >> >> >> -- >> Alexey Samsonov, MSK _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
