On Wed, Mar 27, 2013 at 6:20 PM, John Thompson <
[email protected]> wrote:

>  struct Entry {
> -  enum Kind {
> +  enum KindType {
>      Tag,
>      Value,
>      Macro
>    } Kind;
> +  static const int NumberOfKinds = 3;
>

Err...

Check out the coding standards for thinks like "kind" enums. I think there
is a much better pattern to follow here:

struct Entry {
  enum EnttryKind {
    EK_Tag,
    EK_Value,
    EK_Macro,
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to