Thanks, this approach is much simpler, please find the updated patch attached.
On 28 March 2013 19:17, Jordan Rose <[email protected]> wrote: > We are a *long* way from that being true. One more violation won't hurt > today. (A quick search shows the same technique being used in > Sema::CheckMain.) > > Jordan > > > On Mar 28, 2013, at 10:03 , Alexander Zinenko <[email protected]> wrote: > > SemaDecl.cpp comment says > > #include "clang/Lex/Preprocessor.h" // FIXME: Sema shouldn't depend on Lex > > that's why I didn't use it. Is it ok to use Preprocessor in Sema? > > > > On 28 March 2013 18:47, Jordan Rose <[email protected]> wrote: > >> I don't think you actually need to pass the range around. >> PP.getLocForEndOfToken should work fine. (Sorry I didn't notice this the >> first time around.) >> >> On Mar 28, 2013, at 9:35 , Alexander Zinenko <[email protected]> wrote: >> >> > Hello >> > >> > This patch adds fixits to -Wreinterpret-base-class proposing to replace >> reinterpret_cast with static_cast. It required passing SourceRange instead >> of SourceLocation through some calls in Sema. >> > >> > Review please! >> > >> > -- >> > Alex >> > >> > <13824fixit.patch>_______________________________________________ >> > cfe-commits mailing list >> > [email protected] >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> > >
13824fixit.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
