On Apr 3, 2013, at 2:46 PM, Nico Weber <[email protected]> wrote:

> Hi,
> 
> the attached patch changes the attributes diag I added earlier today from
> 
>   test2.mm:3:12: error: postfix attributes are not allowed on Objective-C 
> directives
> 
> to 
> 
>   test2.mm:3:12: error: postfix attributes are not allowed on Objective-C 
> directives, place them in front of '@interface'
> 
> for @interface and @protocol (and keeps the diagnostic as is for @class and 
> @implementation).

What is the rational for hint for @interface/@protocol and not others ?

-@implementation EXP I @end // expected-error {{postfix attributes are not 
allowed on Objective-C directives}}
+@implementation EXP I @end // expected-error-re {{postfix attributes are not 
allowed on Objective-C directives$}}
                                                                              
????                                                                            
            ??????

-@class EXP OC; // expected-error {{postfix attributes are not allowed on 
Objective-C directives}}
+@class EXP OC; // expected-error-re {{postfix attributes are not allowed on 
Objective-C directives$}}

These don’t look right.

Also, why can’t you pass the token down instead of adding and using "enum 
ObjCAttrSkipHint”?

- Fariborz

> 
> Ok?
> 
> Nico
> <clang-objc-attrs-2.patch>_______________________________________________
> cfe-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to