On Apr 10, 2013, at 20:53 , Anna Zaks <[email protected]> wrote: > Ryan, > > The patch looks good to me. See a couple of minor comments below. > > Cheers, > Anna. > > - Profile(ID, LHS, Op, RHS, T); > + Profile(ID, LHS, this->getOpcode(), RHS, this->getType()); > > Is there a reason you are using 'this' instead of just calling the getter? > > +/// SymIntExpr - Represents symbolic expression like 'x' + 3. > > We use doxygen style comments in the later commits. For example, see the > comment for RuntimeDefinition class in CallEvent.h.
In particular, please don't repeat the name of the class in the doc comment. Jordan _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
