On Tue, Apr 16, 2013 at 3:50 PM, David Blaikie <[email protected]> wrote:
> > On Apr 17, 2013 6:37 AM, "Richard Trieu" <[email protected]> wrote: > > > > On Tue, Apr 16, 2013 at 12:47 AM, David Blaikie <[email protected]> > wrote: > >> > >> On Tue, Apr 9, 2013 at 3:06 PM, Richard Trieu <[email protected]> > wrote: > >> > Author: rtrieu > >> > Date: Tue Apr 9 17:06:27 2013 > >> > New Revision: 179131 > >> > > >> > URL: http://llvm.org/viewvc/llvm-project?rev=179131&view=rev > >> > Log: > >> > Remove outdated run lines from tests. > >> > > >> > These run lines originally tested that the fix-its were properly > applied. > >> > Originally, the fixits were attached to warnings and were applied by > -fixit. > >> > Now, the fixits are attached to notes, so nothing happens. These run > lines > >> > still manage to pass since Clang will produce an empty output which > gets piped > >> > back to Clang. > >> > >> Is that a bug? That seems like a bug. > > > > > > I'm not sure. I don't think -fixit ever supported -o. > > Perhaps not explicitly/deliberately, but I assume under some conditions it > was producing some kind of valid c++ on stdout, otherwise that lit test > would've failed, right? Or perhaps I'm missing something here. > > Yeah, I don't understand why this test ever would've passed. The second > command should have always failed. -o should set the output of the command > which should be the object file, not the modified source... > I didn't see Clang produce any output with -fixit and -o. It passes because the next Clang command is run on an empty input, for which Clang does not produce any errors. > >> > >> > >> > Then Clang produces no error on an empty input. > >> > > >> > Modified: > >> > cfe/trunk/test/Sema/parentheses.c > >> > cfe/trunk/test/Sema/parentheses.cpp > >> > > >> > Modified: cfe/trunk/test/Sema/parentheses.c > >> > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/parentheses.c?rev=179131&r1=179130&r2=179131&view=diff > >> > > ============================================================================== > >> > --- cfe/trunk/test/Sema/parentheses.c (original) > >> > +++ cfe/trunk/test/Sema/parentheses.c Tue Apr 9 17:06:27 2013 > >> > @@ -1,5 +1,4 @@ > >> > // RUN: %clang_cc1 -Wparentheses -fsyntax-only -verify %s > >> > -// RUN: %clang_cc1 -Wparentheses -fixit %s -o - | %clang_cc1 > -Wparentheses -Werror - > >> > > >> > // Test the various warnings under -Wparentheses > >> > void if_assign(void) { > >> > > >> > Modified: cfe/trunk/test/Sema/parentheses.cpp > >> > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/parentheses.cpp?rev=179131&r1=179130&r2=179131&view=diff > >> > > ============================================================================== > >> > --- cfe/trunk/test/Sema/parentheses.cpp (original) > >> > +++ cfe/trunk/test/Sema/parentheses.cpp Tue Apr 9 17:06:27 2013 > >> > @@ -1,5 +1,4 @@ > >> > // RUN: %clang_cc1 -Wparentheses -fsyntax-only -verify %s > >> > -// RUN: %clang_cc1 -Wparentheses -fixit %s -o - | %clang_cc1 > -Wparentheses -Werror - > >> > > >> > bool someConditionFunc(); > >> > > >> > > >> > > >> > _______________________________________________ > >> > cfe-commits mailing list > >> > [email protected] > >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
