On Tuesday, April 16, 2013 3:51 PM, Douglas Gregor wrote:

+  PragmaMessageHandler(PPCallbacks::PragmaMessageKind Kind,
+                       StringRef Namespace = StringRef())
+    : PragmaHandler(PragmaKind(Kind) + 7),

This "+7" is a bit too magical. Please turn it into a separate function with a switch.

Otherwise, LGTM!

- Doug

Doug,

Thanks, I've made the change and it is committed in r179687.

Andy


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to