On Wed, Apr 17, 2013 at 10:06 AM, Jordan Rose <[email protected]> wrote: > Yeah, I think that's better than trying to run around blacklisting all the > systems without TLS. (For the silly example, think of David Fang's darwin8 > project.) > > Yes, it would make sense to have per-system TLS tests, but those seem like > backend tests or integration tests, not semantic analysis regression tests. >
No disagreement here. I'll just make it depend on x86_64-linux then. -eric > Jordan > > > On Apr 17, 2013, at 9:51 , Eric Christopher <[email protected]> wrote: > >> Do you mean to the invocation line? That was the other option - I had >> no good feeling either way on the test at the time, but I could do >> that. Had some reason that I didn't want to restrict the test, but in >> the grand scheme of things that might be silly. >> >> -eric >> >> On Wed, Apr 17, 2013 at 9:42 AM, Jordan Rose <[email protected]> wrote: >>> Um, can't you just add a target triple? This is a Sema test. >>> >>> Jordan >>> >>> On Apr 17, 2013, at 0:19 , Eric Christopher <[email protected]> wrote: >>> >>>> Author: echristo >>>> Date: Wed Apr 17 02:19:56 2013 >>>> New Revision: 179671 >>>> >>>> URL: http://llvm.org/viewvc/llvm-project?rev=179671&view=rev >>>> Log: >>>> Add a bit of a hack to deal with a failing testcase on darwin10 bots. >>>> >>>> We currently emit an error message when you try to use thread local >>>> storage on targets that don't support it and testing C++11 thread >>>> locals will trip this. We don't want to xfail the test for all darwin >>>> hosts so add a quick hack to check for darwin10 and disable the >>>> test based on that. Only checking darwin10 because anything earlier >>>> is really old and I don't have a list of what other hosts don't >>>> support tls handy. >>>> >>>> Alternate suggestions welcome! >>>> >>>> Modified: >>>> cfe/trunk/test/SemaCXX/cxx11-thread-local.cpp >>>> cfe/trunk/test/lit.cfg >>>> >>>> Modified: cfe/trunk/test/SemaCXX/cxx11-thread-local.cpp >>>> URL: >>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/cxx11-thread-local.cpp?rev=179671&r1=179670&r2=179671&view=diff >>>> ============================================================================== >>>> --- cfe/trunk/test/SemaCXX/cxx11-thread-local.cpp (original) >>>> +++ cfe/trunk/test/SemaCXX/cxx11-thread-local.cpp Wed Apr 17 02:19:56 2013 >>>> @@ -1,4 +1,5 @@ >>>> // RUN: %clang_cc1 -std=c++11 -verify %s >>>> +// REQUIRES: thread_local_storage >>>> >>>> struct S { >>>> static thread_local int a; >>>> >>>> Modified: cfe/trunk/test/lit.cfg >>>> URL: >>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=179671&r1=179670&r2=179671&view=diff >>>> ============================================================================== >>>> --- cfe/trunk/test/lit.cfg (original) >>>> +++ cfe/trunk/test/lit.cfg Wed Apr 17 02:19:56 2013 >>>> @@ -305,3 +305,7 @@ if config.llvm_use_sanitizer == "Address >>>> if (config.llvm_use_sanitizer == "Memory" or >>>> config.llvm_use_sanitizer == "MemoryWithOrigins"): >>>> config.available_features.add("msan") >>>> + >>>> +# Thread local storage >>>> +if not 'darwin10' in config.target_triple: >>>> + config.available_features.add("thread_local_storage") >>>> >>>> >>>> _______________________________________________ >>>> cfe-commits mailing list >>>> [email protected] >>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>> > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
