On Apr 17, 2013, at 17:15 , Anna Zaks <[email protected]> wrote:

> +  // This is not valid C++; dynamic_cast with a reference type will throw an
> +  // exception if the pointer does not match the expected type. However, our
> +  // implementation of dynamic_cast will pass through a null pointer...or a
> +  // "null reference"! So this branch is actually possible.
> +  if (&val == 0) { //expected-note {{Assuming pointer value is null}}

I know this is just a test, but the comment is bogus. Instead it's something 
like this:

// This is not valid C++; if 'ptr' were null, creating 'ref' would be illegal.
// However, this is not checked at runtime, so this branch is actually possible.

Not sure if that's 80 cols or more.
Jordan
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to