Hi Rafael, Is it okay to commit the patch while we're waiting to learn more about the test? In either case, this is a valid change since we don't want the test to depend on the system header files.
Thanks, Jyotsna -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation >-----Original Message----- >From: Rafael Espíndola [mailto:[email protected]] >Sent: Tuesday, April 23, 2013 11:02 AM >To: Jyotsna Verma >Cc: llvm cfe; Douglas Gregor >Subject: Re: [PATCH] Fix SemaTemplate/example-dynarray.cpp to use explicit >declaration of malloc, free and assert. > >This test looks really odd. It seems designed to be an execution test (has a >main function, uses assert), but we only produce IL from it. It has been odd >since it was added in r72437. > >Douglas, what was the intent of this test? Should it be moved to the llvm- >testsuite where it will actually be executed? > >On 23 April 2013 11:44, Jyotsna Verma <[email protected]> wrote: >> The attached patch modifies SemaTemplate/example-dynarray.cpp test to >> have explicit declaration for malloc, free and assert functions and >> removes its dependency on <stdlib.h> and <assert.h>. >> >> >> >> Please let me know if the patch is okay to commit. >> >> >> >> Thanks, >> >> Jyotsna >> >> >> >> -- >> >> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, >> hosted by The Linux Foundation >> >> >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
