generally lg
================
Comment at: lib/Format/WhitespaceManager.cpp:96
@@ +95,3 @@
+ return;
+ }
+ std::string ReplacementText =
----------------
I'd go with else instead of early return here.
================
Comment at: lib/Format/WhitespaceManager.cpp:72
@@ +71,3 @@
+ } else {
+ unsigned MinColumn = WhitespaceStartColumn + 2;
+ unsigned MaxColumn = Style.ColumnLimit;
----------------
Please comment on the +2 here, and the -2 below so it's clear how the algorithm
works.
http://llvm-reviews.chandlerc.com/D725
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
