Hi Peter, Anders,

I was reading the source of Clang VTableBuilder sources to get
familiar with the code before writing a vftable generator for
Microsoft ABI.

I've decided to improve a couple of comments.
After improving one of the comments, fixing one of the FIXMEs in the
code became obvious, so I went ahead and just did it.
Please see the attached patch!

I also have a couple of questions, see the TODOs in the patch.
The most important is VTableBuilder::ComputeThisAdjustmentBaseOffset
where it's a bit unclear what's going on. It would be nice if we could
come up with a code which is easier to understand or at least a good
comment there.

Thanks!
--
Timur Iskhodzhanov,
Google Russia

Attachment: vtables_comments.patch
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to