Thanks, I ran clang-format over it then committed as r180702.
On Fri, Apr 26, 2013 at 9:13 AM, Will Wilson <[email protected]> wrote: > Hi Richard, > > Thanks for the review! > > > On 26 April 2013 17:23, Richard Smith <[email protected]> wrote: > >> Change LGTM, thanks. >> >> + if (ClassTemplatePartialSpecializationDecl* MD = >> + >> dyn_cast_or_null<ClassTemplatePartialSpecializationDecl>(*II)) { >> + TemplateParamScopeStack.push_back(new ParseScope(this, >> + >> Scope::TemplateParamScope)); >> + Actions.ActOnReenterTemplateScope(getCurScope(), MD); >> + } else if (CXXRecordDecl* MD = dyn_cast_or_null<CXXRecordDecl>(*II)) >> { >> + TemplateParamScopeStack.push_back(new ParseScope(this, >> + >> Scope::TemplateParamScope, >> + MD->getDescribedClassTemplate() != >> 0 )); >> >> Can you fix the formatting of this code too? :) There's some strange >> indentation here (probably due to 80-column limits) and an extra space >> after the 0. Also a typo "outmost" should be "outermost". >> > > I've attempted to fix the indenting but I've had to break out an argument > in the process, either way I don't think it hinders clarity. Incidentally > "outmost" is valid if archaic, but I've changed it anyhow. > > Let me know if there's anything else, otherwise - over to you! > > - Will. > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
