I agree with Richard on this one. Just add the template case to cpp11-migrate code.
By the way, your patch actually fixes another known bug assigned to someone else: http://llvm.org/bugs/show_bug.cgi?id=15827 From: [email protected] [mailto:[email protected]] On Behalf Of Richard Smith Sent: Sunday, April 28, 2013 5:09 PM To: Guillaume Papin Cc: cfe commits Subject: Re: [PATCH] Add CXXMethodDecl::getInlineBody() and fix cpp11-migrate segfault I'm not convinced this is the right approach: getInlineBody has weird semantics and thus it doesn't seem like a good fit as a general purpose AST interface. It would make a lot more sense to me to have the fallback to the template in the cpp11-migrate code, where it can also handle other consequences of this, such as classifying such a fix as "risky" (because it might not be correct for every instantiation). On Sun, Apr 28, 2013 at 7:21 AM, Guillaume Papin <[email protected]<mailto:[email protected]>> wrote: Uh, embarrassing, of course I failed the attachments: -- Guillaume Papin _______________________________________________ cfe-commits mailing list [email protected]<mailto:[email protected]> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
