On Apr 29, 2013, at 16:08 , Ted Kremenek <[email protected]> wrote:
> On Apr 29, 2013, at 4:02 PM, Jordan Rose <[email protected]> wrote: >> I'm fairly sure flattening can still cause problems for when diagnostics are >> output twice, because PathDiagnosticPiece objects that contain path segments >> themselves really do need to be copied to make them independent. I don't >> think we really have a way to "share" the path pieces unless we have some >> kind of deepCloneNoLeaves() method. > > I took a look at the flattening. It really looks like we are either doing > straight sharing or we conjure up new events. The flattening essentially > does a deep clone. Ah, yes, I see. Other than that FIXME for macros, which should not be made worse by this.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
