================ Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:88 @@ +87,3 @@ + /// \c parseMatcher function is a better approach to get a matcher object. + static bool parseValue(llvm::StringRef Code, TokenProcessor *Processor, + VariantValue *Value, Diagnostics *Error); ---------------- Manuel Klimek wrote: > Nit: since this is not the preferred interface, I would put it below > parseMatcher. Done
================ Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:102 @@ +101,3 @@ + static DynTypedMatcher *parseMatcher(llvm::StringRef MatcherCode, + TokenProcessor *Processor, + Diagnostics *Error); ---------------- Manuel Klimek wrote: > For the future: I'd like an overload that doesn't need the TokenProcessor :) Done. Now I don't even need to expose the default registry-based implementation. http://llvm-reviews.chandlerc.com/D714 BRANCH svn ARCANIST PROJECT clang _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
