Thank you for the patch. Indentation width is an important setting to configure. However, having a command-line option just for it doesn't seem to be a good idea. We could either expose all formatting options as command-line flags or read them from configuration files. The latter seems more usable, and we've already started working on support for configuration files.
As for the rest of the patch, it looks rather reasonable, but it definitely needs tests. On Sun, May 5, 2013 at 7:44 PM, Nitram Aw <[email protected]> wrote: > Clang-format seems to be hard coded to use two space width indentation. > To make it useful to a broader audience I suggest getting rid of this > limitation > by letting it be part of the FormatStyle. > > I added IndentationWidth to FormatStyle. > I used IndentationWidth instead of 2 the places that seem most important. > I added -iw as a switch to clang-format to override selected style. > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > -- Alexander Kornienko | Software Engineer | [email protected] | +49 151 221 77 957 Google Germany GmbH | Dienerstr. 12 | 80331 München
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
