My first gut feeling reaction is that we'll want a different solution than to 
make DynTypedNode more complex, and thus less predictable.

  We had a reason for have the explicit overloads in the ASTMatchFinder instead 
of just working on the interface - the problem is that you can otherwise hand 
in lots of matchers that are impossible to get a match with...

  Things we could consider:
  1. take a DynTypedMatcher* and take ownership - together with clone(), this 
allows users to do everything they need, and doesn't lead to overload confusion.
  2. only have the DynTypedMatcher interface, and somehow break dynamically 
with an error message
  other ideas?

http://llvm-reviews.chandlerc.com/D714

BRANCH
  svn

ARCANIST PROJECT
  clang
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to