Thank you for reviewing. Made it to store the location of the trigraph or whitespace. New patch is attached. You can also review the same patch at http://llvm-reviews.chandlerc.com/D777.
On Thu, May 9, 2013 at 10:33 AM, Richard Smith <[email protected]>wrote: > This mostly looks fine, but please store the location of the trigraph or > whitespace-after-backslash so that you can give a more > accurately-positioned diagnostic. You can use expected-warning@OFFSET to > expect a warning on a different line. > > On Wed, May 8, 2013 at 9:40 PM, Rui Ueyama <[email protected]> wrote: > >> Ping? >> >> >> On Tue, Apr 16, 2013 at 5:35 AM, Chandler Carruth >> <[email protected]>wrote: >> >>> There are lots of other folks who can take a look, including Richard, >>> Doug, Argiris, etc... Unfortunately some of us are tied up in C++ standard >>> committee meetings, but there should be replies before too long... >>> >>> >>> On Tue, Apr 16, 2013 at 5:28 AM, Rafael Espíndola < >>> [email protected]> wrote: >>> >>>> On 16 April 2013 04:00, Rui Ueyama <[email protected]> wrote: >>>> > Yes, I think the new while-loop is not in a very hot path, as it is >>>> executed >>>> > only when there's a '/' at the very beginning of a line in a block >>>> comment. >>>> > And it loops only when previous lines are continuation lines. That >>>> should be >>>> > pretty unusual. I think that's why this minor bug was not found until >>>> now :) >>>> > >>>> > Can anyone else take a look? >>>> >>>> Chris I guess. He is not on code owners for it must I think most of >>>> the lexer is still his. >>>> >>>> Cheers, >>>> Rafael >>>> _______________________________________________ >>>> cfe-commits mailing list >>>> [email protected] >>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>>> >>> >>> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> >
block-comment-fix2.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
