Makes sense. Thanks for simplifying it :) -eric
On Thu, May 9, 2013 at 1:48 PM, David Blaikie <[email protected]> wrote: > Author: dblaikie > Date: Thu May 9 15:48:12 2013 > New Revision: 181542 > > URL: http://llvm.org/viewvc/llvm-project?rev=181542&view=rev > Log: > Debug Info: Remove unnecessary check for dependent array types > > This was added, untested (though the relevant crash was tested), in > r128725/PR9600. Removing it doesn't cause failures & nothing I can > imagine could cause this check to ever return 'true' (we should never be > dealing with dependent types here). The subsequent change to check > "isIncompleteType" (r128855/PR9608) makes a lot more sense. > > Modified: > cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > > Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=181542&r1=181541&r2=181542&view=diff > ============================================================================== > --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original) > +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Thu May 9 15:48:12 2013 > @@ -1585,7 +1585,7 @@ llvm::DIType CGDebugInfo::CreateType(con > Align = 0; > else > Align = CGM.getContext().getTypeAlign(Ty->getElementType()); > - } else if (Ty->isDependentSizedArrayType() || Ty->isIncompleteType()) { > + } else if (Ty->isIncompleteType()) { > Size = 0; > Align = 0; > } else { > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
