On Fri, May 10, 2013 at 6:14 AM, Faisal Vali <[email protected]> wrote:
> As I was working on captures within Generic Lambdas, I thought it would be > nice to refactor the very long function : tryCaptureVariable. Please let me > know if you think this refactoring is useful and if you have any > suggestions for improving the refactoring. > > Also, I fixed a bug in my initial TemplateParameterDepth patch - the Depth > counter was getting incremented when it shouldn't have (that is for a > non-class template) in delayed-template parsing mode. I included a test > that previously asserted, and now compiles and behaves as it should. In general I think it would be very good to separate out these two patches (and similarly separable patches). I think getting the bug fix reviewed and in should be done independently of refactoring which doesn't change functionality.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
