As per Chandler's suggestion to separate out the bug fix from the refactoring - see comment below regarding this bug fix patch.
Thank you! Faisal Vali On Thu, May 9, 2013 at 11:36 PM, Chandler Carruth <[email protected]>wrote: > > On Fri, May 10, 2013 at 6:14 AM, Faisal Vali <[email protected]> wrote: > >> As I was working on captures within Generic Lambdas, I thought it would >> be nice to refactor the very long function : tryCaptureVariable. Please let >> me know if you think this refactoring is useful and if you have any >> suggestions for improving the refactoring. >> >> Also, I fixed a bug in my initial TemplateParameterDepth patch - the >> Depth counter was getting incremented when it shouldn't have (that is for a >> non-class template) in delayed-template parsing mode. I included a test >> that previously asserted, and now compiles and behaves as it should. > > > In general I think it would be very good to separate out these two patches > (and similarly separable patches). I think getting the bug fix reviewed and > in should be done independently of refactoring which doesn't change > functionality. >
template-parameter-depth-fix-dont-increment-if-not-classtemplate.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
