I don't think clang's code is currently good enough in that area to matter much. We need a refactoring around target description anyway, and it won't be now. :-)
LGTM. Cheers, Renato On 13 May 2013 23:18, "Rafael Espíndola" <[email protected]> wrote: > On 13 May 2013 18:02, JF Bastien <[email protected]> wrote: > > I don't feel strongly about it (and don't know the codebase much) but > > there's similar code here: > > lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp > > > > I'll defer to those who know LLVM better than I do for this, and it > > otherwise looks good to me. > > Thanks for the pointer, but I don't think it would help a lot in this > case. The version is still returned as "+v7" or "+v6". I assume at > some point a "+v8" will be added, so we would still have to parse it > on our end. > > Renato, what do you think? > > Cheers, > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
