This looks good as far as it goes. However, anyone who calls the non-InChars 
version of getTypeInfo etc is still in danger. That includes many of the 
recursive calls in getTypeInfoImpl, for things like ParenType, DecltypeType, 
ElaboratedType, ...

  Ultimately, maybe we should be removing the non-InChars version, since there 
are types for which it simply cannot return a correct value. Are there any 
types for which both the size and alignment are not an exact number of 
CharUnits? (I would have thought this was obvious, but your GCC alignment 
attribute example has me questioning everything now...)

http://llvm-reviews.chandlerc.com/D781
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to