Thanks for the review Richard! On Mon, May 13, 2013 at 8:48 PM, Richard Smith <[email protected]> wrote: > On Mon, May 13, 2013 at 9:49 AM, Hans Wennborg <[email protected]> wrote: >> The attached patch fixes Clang's diagnostics concerning string >> initialization. > > Looks good, but how about changing IsStringInit to return a > StringInitFailureKind value? I think the two places which use its return > value rather than just using the same Expr* they passed in are actually > wrong (they pass the IgnoreParens'd version of the return value to > CheckStringInit rather than passing in the original expression, and thus may > fail to update the type on the parens).
Sounds good to me. Attaching new patch. OK to commit? Thanks, Hans
string-init-diags2.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
