Please move the tests into test/CodeGenCXX, merge into existing test files, and ensure that -emit-llvm is on the RUN: line. Maybe cxx11-thread-local.cpp for the first test and anonymous-namespaces.cpp for the second one?
Otherwise, LGTM, thanks! On Wed, May 15, 2013 at 6:17 AM, Enea Zaffanella <[email protected]>wrote: > On 05/14/2013 10:21 PM, Richard Smith wrote: > >> The call to hasExternalFormalLinkage in CGDecl.cpp should be to >> hasExternalStorage. Consider: >> >> namespace { >> int a; >> >> int f() { >> extern int a; >> return a; >> } >> } >> >> Here, the 'a' inside 'f' has InternalLinkage but ExternalStorage. We >> definitely don't want to emit that as an automatic-storage-duration >> variable. Please also add an assert(D.hasLocalStorage()) before the call >> to EmitAutoVarDecl. >> > > > Done as suggested (added both testcases). > > Enea. > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
