Is there anything I can do to get this patch moved forward?

Thanks,
- Seth

Begin forwarded message:

From: Seth Fowler <[email protected]>
Subject: Re: [PATCH] Add a way to check if a method declaration is pure virtual to libclang
Date: May 12, 2013 6:30:21 PM PDT
To: Dmitri Gribenko <[email protected]>
Cc: cfe-commits cfe <[email protected]>

Hi Dmitri,

You got it. An updated patch is attached. I wasn't precisely sure what you intended with regards to the member function template test, since those can't be pure virtual; I assumed you wanted to test that they _weren't_ marked as pure.

Thanks,
- Seth

Attachment: add-pure-virtual-query-to-libclang.patch
Description: Binary data



On May 8, 2013, at 5:37 AM, Dmitri Gribenko <[email protected]> wrote:

On Wed, May 8, 2013 at 9:43 AM, Seth Fowler <[email protected]> wrote:
One problem I've encountered is that there doesn't seem to be any way to determine if a method declaration is pure virtual (other than perhaps dropping to the token level). This information is readily available in the clang AST so it seems a shame not to expose it to libclang. Here's a patch to do just that.

Hi Seth,

Please add a test.  You are already extending c-index-test to print
the relevant information.  Just add the relevant test cases (member
function, member function template) in a separate class in
test/Index/overrides.cpp.

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <[email protected]>*/


_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to