On Fri, May 17, 2013 at 6:31 AM, Rafael EspĂ­ndola <
[email protected]> wrote:

> On 11 May 2013 15:26, Robert Wilhelm <[email protected]> wrote:
> > This patch converts three methods to ArrayRef in Sema.
> > No functionality change.
> > Passes make test on x86_64-unknown-linux-gnu
>
> -  if (TypeMayContainAuto && NumDecls > 1) {
> +  if (TypeMayContainAuto && !Group.empty()) {
>
> Should be 'Group.size() > 1' no?
>
> -      Group++;
> -      NumDecls--;
> +      Group.slice(1);
>
> slice returns a new array ref, it doesn't modify the current one.


& if these mistakes weren't causing test failures - perhaps you could
figure out which tests are missing & add them :)

- David
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to