Also, I'd suggest to not submit what phabricator produces - those messages contain way too much noise for the signal.
On Sun, May 19, 2013 at 1:08 PM, Alexander Kornienko <[email protected]>wrote: > I thought it should be rather clear. But if you think otherwise, I'll try > to explain: > This commit adds support for specifying style configuration in yaml/json > format directly as a value of -style command-line option, e.g. > -style="{BasedOnStyle: llvm, IndentWidth: 8}". In addition to that it > improves getPredefinedStyle method and code handling default style (when no > -style specified on command line, or when an invalid style specified, or > when BasedOnStyle parameter is not specified in the used .clang-format > file, or when BasedOnStyle contains invalid style name). "Improved" here > means that there's now only one place where default style name is > specified, and fewer places where it's used. > > Is this detailed enough? > > > On Sun, May 19, 2013 at 6:58 AM, Chandler Carruth <[email protected]>wrote: > >> >> On Sun, May 19, 2013 at 12:53 AM, Alexander Kornienko >> <[email protected]>wrote: >> >>> Clang-format: allow -style="{yaml/json}" on command line >>> >>> Summary: + improved handling of default style and predefined styles. >>> >> >> This description doesn't make a whole lot of sense... Can you clarify >> what is in this commit? (And watch out for this in the future, or fix >> whatever tool if it is a tool that messes this up?) >> > > > > -- > Alexander Kornienko | Software Engineer | [email protected] | +49 151 221 > 77 957 > Google Germany GmbH | Dienerstr. 12 | 80331 München > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
