LGTM for me with one suggestion, but please note that I'm not an approver for this code, so talk to John for the final review.
================ Comment at: lib/CodeGen/CGCXXABI.h:322 @@ +321,3 @@ + /// Returns true if the ABI requires that we emit a definition for this + /// function, given that we don't have a definition for it in the TU. + virtual bool NeedsBodylessEmission(GlobalDecl GD); ---------------- Would be nice to give an example of when it's needed, otherwise it's a bit cryptic. http://llvm-reviews.chandlerc.com/D820 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
