On Tue, May 21, 2013 at 11:53 AM, Lawrence Crowl <[email protected]> wrote:
> On 5/20/13, Manuel Klimek <[email protected]> wrote: > > ================ > > Comment at: lib/Lex/PPDirectives.cpp:573-582 > > @@ +572,12 @@ > > + ModuleMap::ModuleHeaderRole Role = SuggestedModule->getRole(); > > + // // Check for consistency between the module header role > > + // // as obtained from the lookup and as obtained from the > module. > > + // // This check is expensive, so enable it when needed. > > + // SmallVectorImpl<const FileEntry *> &PvtHdrs > > + // = RequestedModule->PrivateHeaders; > > + // SmallVectorImpl<const FileEntry *>::iterator Look > > + // = std::find(PvtHdrs.begin(), PvtHdrs.end(), FE); > > + // bool IsPrivate = Look != PvtHdrs.end(); > > + // assert((IsPrivate && Role == ModuleMap::PrivateHeader) > > + // || (!IsPrivate && Role != ModuleMap::PrivateHeader)); > > + if (Role == ModuleMap::PrivateHeader) { > > ---------------- > > This looks unintentionally left as a comment? > > It was left intentionally, so that it could be enabled when needed. Please uncomment it and wrap in an #ifndef NDEBUG.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
