Yeah, this is pretty much what I was thinking as well; the missing piece in my 
mind was that it has to run after regular optimization has hit its 
steady-state. But why is this pass working on statement-locations, instead of 
just flattening to a FullSourceLoc regardless of how the PathDiagnosticLocation 
was specified? (PathDiagnosticLocation::asLocation).


On May 22, 2013, at 11:52 , Ted Kremenek <[email protected]> wrote:

> +      PathPieces::iterator PieceToErase = I;
> +      ++I;
> +      erased = true;
> +      path.erase(PieceToErase);

This is better written "I = path.erase(I)" (and still "erased = true", of 
course).

Jordan
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to