LGTM with minor comment.
================ Comment at: test/Driver/sanitizer-ld.c:184 @@ +183,3 @@ +// CHECK-LSAN-ASAN-LINUX: libclang_rt.asan-x86_64 +// CHECK-LSAN-ASAN-LINUX: "-lpthread" +// CHECK-LSAN-ASAN-LINUX-NOT: "-lstdc++" ---------------- Here you test that lsan and asan are not added to ld invocation together. Please use: CHECK: ld CHECK-NOT: libclang_rt.lsan // No lsan between "ld" and "asan" CHECK: libclang_rt.asan CHECK-NOT: libclang_rt.lsan // No lsan after "asan" You may drop pthread and lstdc++ http://llvm-reviews.chandlerc.com/D837 BRANCH feat/fsanitize_leak ARCANIST PROJECT clang _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
