What's the status of this patch? I ran it on a large body of code, and I still see issues with ptr_fun, if that sheds any light on the situation. MSVC's ptr_fun doesn't have an implicit cc specialization. It has specializations for __cdecl, __stdcall, and __fastcall.
On Tue, May 7, 2013 at 3:47 PM, Richard Smith <[email protected]> wrote: > I believe your check for IsStatic in CheckFunctionCCAttr is incorrect for > operator new/operator delete (which are implicitly static). Also, walking > the DeclaratorChunks will not do the right thing for a function type which > is produced by a type specifier (eg, using a typedef for a function type), > and the code will crash for a declaration which has no DeclaratorChunks. > Can you delay this checking until after the FunctionDecl is built? (That > would also make the CXXABI checking interface nicer; you could pass in the > FunctionDecl and ask "is this valid?") > > On Mon, Apr 29, 2013 at 9:03 AM, Alexander Zinenko <[email protected]>wrote: > >> Hello, John! >> >> Do you have time to review this? >> >> >> On Thursday, April 18, 2013, Alexander Zinenko wrote: >> >>> > I would just suppress all this checking whenever the declaration has a >>> scope qualifier and let redeclaration checking handle it. >>> >>> Right, redeclaration checking suffice here, thanks. >>> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> >> > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
