You may want to comment the get_id call for now. The rest looks good.

================
Comment at: cpp11-migrate/Core/PerfSupport.cpp:41
@@ +40,3 @@
+  llvm::sys::self_process *SP = llvm::sys::process::get_self();
+  unsigned Pid = SP->get_id();
+  llvm::TimeRecord T = llvm::TimeRecord::getCurrentTime();
----------------
I'm looking into a fix for this, but I don't have any machine to test.

================
Comment at: cpp11-migrate/Core/PerfSupport.cpp:57
@@ +56,3 @@
+    // Terminate the last source with a comma before continuing to the next 
one.
+    if (I != TimingResults.begin())
+      FileStream << ",\n";
----------------
This is a much better approach (no hanging comma).


http://llvm-reviews.chandlerc.com/D912
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to