I was thinking the same thing. The windows implementation of get_id() is not very useful. The docs for llvm::sys::process::id_type say it's void* on Windows because they don't want to draw in the windows headers to define HANDLE and void* is the documented type of HANDLE. However, GetCurrentProcessId() returns a DWORD which is documented to be unsigned long from what I can see so I'd be in favour of changing it.
> -----Original Message----- > From: Kim Gräsman [mailto:[email protected]] > Sent: Wednesday, June 05, 2013 6:45 AM > To: Vane, Edwin > Cc: llvm cfe > Subject: Re: [clang-tools-extra] r183154 - cpp11-migrate: turn off PID-based > perf data filenames > > On Mon, Jun 3, 2013 at 11:14 PM, Edwin Vane <[email protected]> wrote: > > Author: revane > > Date: Mon Jun 3 16:14:24 2013 > > New Revision: 183154 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=183154&view=rev > > Log: > > cpp11-migrate: turn off PID-based perf data filenames > > > > Getting PIDs on Windows is broken. Proper fix is simple but requires > > testing so just disabling PID-based file names for now. > > I can cook up a patch to change the Windows implementation to use PIDs > instead of process handles. I can't find any uses of > llvm::sys::process::get_id() in LLVM + Clang (I don't have tools or other > related > projects checked out), so it should be relatively safe. > > If I post it to Phabricator, can someone take a look and commit it to the LLVM > tree for me? > > Thanks, > - Kim _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
